Skip to content

Mirror: fix admin verb to set unspawned ballisic ammo count #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2024
Merged

Mirror: fix admin verb to set unspawned ballisic ammo count #375

merged 2 commits into from
May 29, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26411: fix admin verb to set unspawned ballisic ammo count from space-wizards space-wizards/space-station-14

451890b85b49e17a0019d107db4a31a48cdd3518

PR opened by IProduceWidgets at 2024-03-24 21:06:57 UTC

PR changed 2 files with 15 additions and 3 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Fixed #26362

Why / Balance

Technical details

I made the UpdateBallisticAppearance function public, I can't think of any reason that's a bad idea.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:ADMIN:

  • fix: setting ballistic ammo counts for a magazine should no longer be able to crash your game.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
FoxxoTrystan
FoxxoTrystan reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DangerRevolution DangerRevolution marked this pull request as ready for review May 20, 2024 22:58
@DangerRevolution DangerRevolution enabled auto-merge (squash) May 20, 2024 22:58
@DangerRevolution DangerRevolution requested review from DangerRevolution and a team May 20, 2024 22:58
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 20, 2024
@DangerRevolution DangerRevolution added Size: 4-Small For small issues/PRs Priority: 5-Whenever Doesn't matter when this gets resolved Status: Needs Review Someone please review this Changes: C# Changes any cs files labels May 20, 2024
@DangerRevolution DangerRevolution merged commit 159ebe4 into Simple-Station:master May 29, 2024
10 checks passed
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Feb 6, 2025
@formlessnameless @VMSolidus
Merge pull request Simple-Station#375 from AirFryerBuyOneGetOneFree/D…
eebff51 
…utch-VanDerLinde-jackets

Add the Ability to Tie Jumpsuit Jackets around Waist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan left review comments

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Priority: 5-Whenever Doesn't matter when this gets resolved Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimpleStation14 @VMSolidus @FoxxoTrystan @DangerRevolution